-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read secrets from command line provided paths, if specified #242
Read secrets from command line provided paths, if specified #242
Conversation
for more information, see https://pre-commit.ci
…e check for undefined now
… have weird behavior with false-y named files in CWD
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I have some small style issues for now, working on reviewing the rest
for more information, see https://pre-commit.ci
//check if the next index is not an option | ||
if (args[optionIndex + 1] && !args[optionIndex + 1].startsWith("--")){ | ||
return args[optionIndex + 1]; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good
Code has been tested for a few cases (passing no arg, passing invalid path, not passing arg at all, and passing a valid file), appears to work as expected |
No description provided.